Skip to content

Conversation

@Marimuthukalivelraja
Copy link
Contributor

Description

This PR adds documentation for the curl-loader component used within the Application Simulator project. It outlines how to define load behavior using the config.json file.

Let me know if you'd like to make some changes regarding this documentation.

Thank you again, and I look forward to your feedback!

Type of Change

  • Documentation

Checklist

  • I have read the contributing guidelines

@Marimuthukalivelraja Marimuthukalivelraja requested review from a team and svrnm as code owners July 26, 2025 17:25
@svrnm
Copy link
Collaborator

svrnm commented Jul 28, 2025

@Marimuthukalivelraja that's a good start, thank you, can you run prettier or any other tool over the markdown for proper formatting? thanks

@Marimuthukalivelraja
Copy link
Contributor Author

Marimuthukalivelraja commented Jul 28, 2025

@svrnm Thanks for my first start. As per your suggestion I make all the changes for sure and comes with new doc

Copy link
Collaborator

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few comments

Marimuthukalivelraja and others added 4 commits August 6, 2025 11:22
removed orphaned spaces

Co-authored-by: Severin Neumann <[email protected]>
Co-authored-by: Severin Neumann <[email protected]>
Co-authored-by: Severin Neumann <[email protected]>
align the spaces in the heading and code snippet section

Co-authored-by: Severin Neumann <[email protected]>
@Marimuthukalivelraja
Copy link
Contributor Author

hi

Marimuthukalivelraja and others added 5 commits August 9, 2025 23:35
Co-authored-by: Severin Neumann <[email protected]>
Co-authored-by: Severin Neumann <[email protected]>
Co-authored-by: Severin Neumann <[email protected]>
Co-authored-by: Severin Neumann <[email protected]>
Co-authored-by: Severin Neumann <[email protected]>
Co-authored-by: Severin Neumann <[email protected]>
@svrnm
Copy link
Collaborator

svrnm commented Aug 29, 2025

hi

appologies for the delay, I was out of office for the last weeks, taking another look, if you still want to make this PR happen:)

@Marimuthukalivelraja
Copy link
Contributor Author

Marimuthukalivelraja commented Aug 29, 2025

Hello @svrnm brother,

Thank you for your suggestions. I’ve implemented all of your suggestions except for the intro section, which is still pending. Unfortunately, my laptop is not functioning properly, and because of this bad luck, I couldn’t work on that one suggestion.

If you feel the current state is acceptable, please feel free to close this issue. I was a bit worried since this is my first contribution, but I’m also very excited to continue contributing once my laptop is fixed.

Signed-off-by: svrnm <[email protected]>
@svrnm
Copy link
Collaborator

svrnm commented Aug 29, 2025

No worries @Marimuthukalivelraja , I applied some changes, I think it should look good now.

New changes require approval from someone other than svrnm because they were the last pusher.

The repository settings are restrictive, I'll need @noMoreCLI to take a look as well to have it merged.

@svrnm
Copy link
Collaborator

svrnm commented Sep 29, 2025

@Marimuthukalivelraja apologies for the delay here, unfortunately neither me nor @noMoreCLI are currently able to merge this PR. I'll figure something out and will keep you updated.

@svrnm
Copy link
Collaborator

svrnm commented Oct 23, 2025

Apologies @Marimuthukalivelraja for letting you hang here, neither @noMoreCLI nor I are able to work on this project anymore right now. We need to figure out ourselves how to proceed, we will keep you posted, but for the time being this PR will be stalled

Copy link
Contributor

@noMoreCLI noMoreCLI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed also by @svrnm

@noMoreCLI noMoreCLI merged commit 93072c7 into cisco-open:main Oct 23, 2025
2 of 9 checks passed
@Marimuthukalivelraja
Copy link
Contributor Author

Thank you guys @svrnm @noMoreCLI for merging my first contribution, this keeps me motivated to go further

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants